[PATCH] D74115: [llvm-readobj][test] - Add a test for --elf-cg-profile option.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D74115#1863400 <https://reviews.llvm.org/D74115#1863400>, @jhenderson wrote:

> In D74115#1863367 <https://reviews.llvm.org/D74115#1863367>, @grimar wrote:
>
> > In D74115#1863351 <https://reviews.llvm.org/D74115#1863351>, @jhenderson wrote:
> >
> > > Aside: why is this switch prefixed with "elf"? I wouldn't think this section is ELF-specific in principle...
> >
> >
> > Hmmm. Should we rename to `--llvm-cg-profile`? Its a LLVM extention first of all.
> >  And if we want to implement the GNU version (that is what I am working on), perhaps it is good idea to all this suffix to emphasise that is not a common GNU option?
>
>
> Seems reasonable to me. If the section does get adopted by GNU, it likely will need to go through some standardisation (e.g. getting a new SHT_* type), so the more generic "--cg-profile" switch can be saved for then.


OK. I'll leave it for a one more follow-up then (+ lets see what others think too).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74115/new/

https://reviews.llvm.org/D74115