[PATCH] D74121: [TargetInstrInfo] Add the isCandidateForCallSiteEntry()

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 6 13:29:21 PST 2020


vsk added a comment.

Hey @djtodoro, thanks for doing this. This patch takes a whitelisting approach, and might be tricky to test. I'm also not sure how to check that it is exhaustively correct.

I had in mind (what seems to me to be) a simpler/generic blacklisting approach. I hope you don't mind, I implemented the alternative in https://reviews.llvm.org/D74159. I believe the rest of your patches in this stack could be rebased on D74159 <https://reviews.llvm.org/D74159> easily.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74121/new/

https://reviews.llvm.org/D74121





More information about the llvm-commits mailing list