[PATCH] D71470: Recommit "[ARM][MVE] findVCMPToFoldIntoVPS"

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVEVPTBlockPass.cpp:146
-    --CmpMI;
-    if (CmpMI->modifiesRegister(ARM::VPR, TRI))
-      break;
----------------
SjoerdMeijer wrote:
> dmgreen wrote:
> > What happened to this modifies register check?
> > 
> > This was the original error I was looking at.
> I think thhat is covered by `RDA->getReachingMIDef()`, which gets the first def of VPR, and looks to me to be equivalent to the `modifiesRegister()` here if I'm not wrong.
> But will take a look at the test case and how that behaves.
Ah, yes. Sorry. The "readsRegister" uses check is what this should have pointed at.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71470/new/

https://reviews.llvm.org/D71470