[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc marked 5 inline comments as done.
pcc added inline comments.


================
Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:87
+	bl	__hwasan_check_x0_2_short               // call outlined tag check
+                                                        // (arguments: x0 = address, x9 = shadow base)
+	ldr	w0, [x0]                                // inline load
----------------
eugenis wrote:
> mention that "2" encodes access type and size. Do we want to expand on how?
First part done. How is probably too much detail so I've left it out.


================
Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:162
+
+  * An associated ``hwasan_globals`` section is emitted for each tagged global,
+    which indicates the address of the global, its size and its tag.
----------------
hctim wrote:
> We have one section for all globals, right? So /s/section is emitted for each tagged global/section is emitted that contains information about the tagged globals/
The globals have individual sections in the object files, it's the linker that concatenates them together. I've updated the document to talk about the linker's role.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74150/new/

https://reviews.llvm.org/D74150