[PATCH] D68065: Propeller: LLD Support for Basic Block Sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Writer.cpp:1627
+
+      const auto *InputSec = dyn_cast<InputSectionBase>(Sec->repl);
+      if (!InputSec || !InputSec->BytesDropped)
----------------
If you use `sec->repl`, there should be tests checking --icf={safe,all}


================
Comment at: lld/ELF/Writer.cpp:1631
+
+      const auto NewSize = InputSec->data().size();
+
----------------
size_t


================
Comment at: lld/ELF/Writer.cpp:1638
+                   << Def->value - InputSec->BytesDropped << " bytes\n");
+        Def->value -= InputSec->BytesDropped;
+        return;
----------------
I am still skeptical about this st_value adjustment. Maybe you could find some introspection programs and check they don't break.

This may sometimes confuse symbolizers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68065/new/

https://reviews.llvm.org/D68065