[PATCH] D74078: [Clang] When using SEH, create a impl instance for CrashRecoveryContext. NFCI.

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 6 16:32:27 PST 2020


aganea added inline comments.


================
Comment at: llvm/lib/Support/CrashRecoveryContext.cpp:196
 // Work around PR44697.
 __attribute__((optnone))
 #endif
----------------
rnk wrote:
> I think optnone has to remain attached to the function using __try, not the filter.
Silly me, of course it's on the function using the __try. Thanks for catching this!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74078/new/

https://reviews.llvm.org/D74078





More information about the llvm-commits mailing list