[PATCH] D74106: [CMake] Use PUBLIC link mode for static libraries

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

Ah, right, I forgot that "linking" includes header dependencies and so on. This makes sense.

Not this diff, but won't a `BUILD_SHARED_LIBS` build still have issues here, since then `Support` will only have a `PRIVATE` dependency on `ZLIB::ZLIB` and libraries which depend on `Support` won't get that dependency? (And if that's not a problem, then I'm wondering why the static case needs to be `PUBLIC` instead of `PRIVATE`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74106/new/

https://reviews.llvm.org/D74106