[PATCH] D44564: [BasicAA] Use PhiValuesAnalysis if available when handling phi alias

Thu Feb 6 13:48:51 PST 2020

asbirlea added a comment.
Herald added a project: LLVM.

In D44564#1153048 <https://reviews.llvm.org/D44564#1153048>, @john.brawn wrote:

> @brzycki pointed out to me a test case where we get a crash with this patch which turns out to be due to BasicAA using stale PhiValuesAnalysis results due to how the legacy pass manager handles pass dependencies. Updated this patch to fix that problem by marking BasicAA as not CFG-only.

Would you mind sharing this test case if this is still the case?
I'd like to understand if we can lift the restriction of marking BasicAA as not CFG-only, and I see no test crashes from making this change at ToT.
Did the changes in https://reviews.llvm.org/rL340613 resolve this?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D44564/new/

https://reviews.llvm.org/D44564