[PATCH] D74075: [mlir][VectorOps] Introduce a `vector.fma` op that works on n-D vectors and lowers to `llvm.intrin.fmuladd`

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: mlir/include/mlir/Dialect/VectorOps/VectorOps.td:384
+    pointwise multiply followed by accumulate. In the particular case of
+    lowering to LLVM, this is guaranteed to lower to the `llvm.fmuladd.*`
+    intrinsic.
----------------
IIRC llvm.fmuladd does not specify the rounding behaviour (mul and add may or may not be fused). 

The way I read the description here it seems like fusion is ecpexted for vector.fma unless I am missing something. It might be worth clarifying the rounding behaviour 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74075/new/

https://reviews.llvm.org/D74075