[PATCH] D68063: Propeller: LLVM support for basic block sections

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a subscriber: echristo.
mehdi_amini added a comment.

I'm too far away from this part of the code to really assess if this is the proper way of plugin into the codegen unfortunately, I'd ask @echristo maybe?



================
Comment at: llvm/include/llvm/CodeGen/CommandFlags.inc:27
 #include "llvm/Target/TargetOptions.h"
+#include <fstream>
 #include <string>
----------------
Is this needed in this file?


================
Comment at: llvm/include/llvm/IR/BasicBlock.h:436
+  Optional<StringRef> getSectionPrefix() const;
+
 private:
----------------
These methods aren't defined (or used) anywhere.



================
Comment at: llvm/include/llvm/ProfileData/PropellerProf.h:20
+
+#endif
----------------
The "propeller-specific" aspect of it seems unrelated to "adding support for basic block sections"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68063/new/

https://reviews.llvm.org/D68063