[PATCH] D74107: [CMake] Use llvm-ar etal for external project build on Darwin
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 6 10:49:17 PST 2020
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
I've never really understood this block, since the `APPLE` and `WIN32/MSVC` conditionals here will reflect the host you're building on and not your actual runtimes target, but this change itself looks fine.
LGTM barring the question about the WIN32 -> MSVC change.
================
Comment at: llvm/cmake/modules/LLVMExternalProjectUtils.cmake:50
set(ARG_TOOLCHAIN_TOOLS clang lld)
- if(NOT APPLE AND NOT WIN32)
+ if(NOT APPLE AND NOT MSVC)
list(APPEND ARG_TOOLCHAIN_TOOLS llvm-ar llvm-lipo llvm-ranlib llvm-nm llvm-objcopy llvm-objdump llvm-strip)
----------------
What's the reason for this part of the change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74107/new/
https://reviews.llvm.org/D74107
More information about the llvm-commits
mailing list