[PATCH] D74142: [GWP-ASan] Use weak abort message definition.
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 6 10:29:53 PST 2020
eugenis added inline comments.
================
Comment at: compiler-rt/lib/gwp_asan/platform_specific/utilities_posix.cpp:13
#ifdef ANDROID
#include <android/set_abort_message.h>
#include <stdlib.h>
----------------
Is this include needed?
================
Comment at: compiler-rt/lib/gwp_asan/platform_specific/utilities_posix.cpp:24
void Check(bool Condition, const char *Message) {
- if (Condition)
+ if (Condition || &android_set_abort_message == nullptr)
return;
----------------
don't just return if the function is not available.
abort()
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74142/new/
https://reviews.llvm.org/D74142
More information about the llvm-commits
mailing list