[PATCH] D73948: [GlobalISel] Legalize more G_FP(EXT|TRUNC) libcalls.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:725
+    if (Size != 32 && Size != 64) {
+      LLVM_DEBUG(dbgs() << "No libcall available for size " << Size << ".\n");
       return UnableToLegalize;
----------------
You can move this under the getFloatTypeForLLT check since it's somewhat redundant


================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp:1205-1206
+  LegalizerHelper Helper(*MF, Info, Observer, B);
+  EXPECT_TRUE(Helper.libcall(*MIBFPExt1) ==
+              LegalizerHelper::LegalizeResult::Legalized);
+
----------------
EXPECT_EQ(Legalized, ...)


================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp:1247-1251
+  EXPECT_TRUE(Helper.libcall(*MIBFPTrunc1) ==
+              LegalizerHelper::LegalizeResult::Legalized);
+
+  EXPECT_TRUE(Helper.libcall(*MIBFPTrunc2) ==
+              LegalizerHelper::LegalizeResult::Legalized);
----------------
Ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73948/new/

https://reviews.llvm.org/D73948