[PATCH] D74119: [NFC][mlir] Adding some helpful EDSC intrinsics

[Alex Zinenko via Phabricator via llvm-commits]

ftynse added inline comments.


================
Comment at: mlir/include/mlir/EDSC/Intrinsics.h:202
 using call = OperationBuilder<mlir::CallOp>;
+using constant_data = ValueBuilder<ConstantOp>;
 using constant_float = ValueBuilder<ConstantFloatOp>;
----------------
Please make sure the name corresponds to the instruction name, e.g. ConstantOp should be just `constant`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74119/new/

https://reviews.llvm.org/D74119