[PATCH] D73713: Fixed non-deterministic GPU intrinsic lowering.

[Julian Gross via Phabricator via llvm-commits]

dfki-jugr added a comment.
Herald added a reviewer: mravishankar.

@mehdi_amini I fully get your point and I totally agree that we should not hide underlying bugs. However, you can argue as soon as two pattern matchers have the same benefit their ordering will be undefinied. In this case, the only possible solution you have, is to change the pattern matcher benefit. 
@herhut We follow your arguments that we should unbreak the build on Windows asap. As mentioned above, this does not solve the general non-determinism issue. However, even if the ordering would be deterministic, we should not rely on intrinsic magic that might be easily broken by another commit in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73713/new/

https://reviews.llvm.org/D73713