[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 6 02:52:48 PST 2020


nhaehnle added a comment.

If people are concerned about virtual function calls, I do think it may be possible to have a generic builder class using virtual dispatch, but also a variant that doesn't use virtual dispatch. I've outlined a possible direction here: https://pastebin.com/i4mC6GAf

That said, I think it's plausible that just using virtual dispatch unconditionally is fine, some superficial compile-time benchmarks would be nice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73835/new/

https://reviews.llvm.org/D73835





More information about the llvm-commits mailing list