[PATCH] D73542: [LLD][ELF][ARM] Do not substitute BL/BLX for non STT_FUNC symbols.

Thu Feb 6 01:58:54 PST 2020

peter.smith added a comment.

In D73542#1861050 <https://reviews.llvm.org/D73542#1861050>, @MaskRay wrote:

> In D73542#1860995 <https://reviews.llvm.org/D73542#1860995>, @thakis wrote:
>
> > In D73542#1860517 <https://reviews.llvm.org/D73542#1860517>, @psmith wrote:
> >
> > > My apologies for the breakage.
> >
> >
> > No worries! Thanks for being very responsive and fixing quickly :) (To both you and maskray.)
>
>
> <del>Please cherry pick 5461fa2b1fcfcfcd8e28e3ac3383d2245d5d90bf <https://reviews.llvm.org/rG5461fa2b1fcfcfcd8e28e3ac3383d2245d5d90bf> to release/10.x :)</del>
>
> edit: We don't need it. D73542 <https://reviews.llvm.org/D73542> is not in release/10.x

5461fa2b1fcfcfcd8e28e3ac3383d2245d5d90bf <https://reviews.llvm.org/rG5461fa2b1fcfcfcd8e28e3ac3383d2245d5d90bf> looks good; thanks very much! As you've pointed out the original fault isn't on 10.x so no need to cherry pick that to the branch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73542/new/

https://reviews.llvm.org/D73542