[PATCH] D74057: [DebugInfo][NFC] Fixup the UserValue methods to use FragmentInfo

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 6 01:23:28 PST 2020


Orlando marked an inline comment as done.
Orlando added a comment.

Thanks for looking at these patches. When they are all ready to land would it be better to land them independently or all together as one?



================
Comment at: llvm/lib/CodeGen/LiveDebugVariables.cpp:196
   /// Does this UserValue match the parameters?
-  bool match(const DILocalVariable *Var, const DIExpression *Expr,
+  bool match(const DILocalVariable *Var,
+             Optional<DIExpression::FragmentInfo> OtherFragment,
----------------
aprantl wrote:
> matches?
It hadn't crossed my mind to rename this. The UserLabel class has a `match()` method too. Would you like me to update both?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74057/new/

https://reviews.llvm.org/D74057





More information about the llvm-commits mailing list