[PATCH] D74058: [ReachingDefs] Make isSafeToMove more strict.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/CodeGen/ReachingDefAnalysis.cpp:398
   for (auto I = ++Iterator(From), E = Iterator(To); I != E; ++I) {
+    if (I->mayStore() || I->hasUnmodeledSideEffects() ||
+        I->isCall() || I->isBranch() || I->isTerminator())
----------------
I was just looking at the similar (but not the same) check in `isSafeToRemove`.
Just quickly checking: that one is also checking for `isReturn`, do we need that here? And here we check for `isCall`, do we need that there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74058/new/

https://reviews.llvm.org/D74058