[PATCH] D74075: [mlir][VectorOps] Introduce a `vector.fma` op that works on n-D vectors and lowers to `llvm.intrin.fmuladd`

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.


================
Comment at: mlir/include/mlir/Dialect/VectorOps/VectorOps.td:382
+  let description = [{
+    Multiply-add expressions that operates on n-D f32 or f64 vectors and lower
+    to the llvm.fmuladd.* intrinsic.
----------------
aartbik wrote:
> typo: that operate (plural)
> 
> but more in general, can you describe the semantics in a bit more detail than this? In particular, the lowering part to llvm could be mentioned at one point as motivation to have this, but it seems a bit strange to mention that in the very first sentence already.
> 
> 
Made the description more general.
There is a notion of guaranteed fmuladd in the LLVM case that I kept.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74075/new/

https://reviews.llvm.org/D74075