[PATCH] D73811: [CMake] Passthrough CMAKE_SYSTEM_NAME to default builtin and runtimes target

[Vlad Vereschaka via Phabricator via llvm-commits]

vvereschaka added a comment.

Hello Petr,

these changes break the Windows to ARM Linux cross builders:
http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4166
http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4144

We pass a proper CMAKE_SYSTEM_NAME for the target build through `BUILTINS_CMAKE_ARGS` and `RUNTIMES_CMAKE_ARGS` variables, such as

  set(BUILTINS_CMAKE_ARGS  "-DCMAKE_SYSTEM_NAME=Linux" CACHE STRING "")
  set(RUNTIMES_CMAKE_ARGS  "-DCMAKE_SYSTEM_NAME=Linux" CACHE STRING "") 

(see `clang/cmake/caches/CrossWinToARMLinux.cmake` for details)

Your change pass a host system name that is Windows in our case and it is incorrect for the build target.

Is there a way to pass a proper system name in that case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73811/new/

https://reviews.llvm.org/D73811