[PATCH] D74078: [Clang] When using SEH, create a impl instance for CrashRecoveryContext. NFCI.

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Seems fine in principle. lgtm with the one issue fixed.



================
Comment at: llvm/lib/Support/CrashRecoveryContext.cpp:196
 // Work around PR44697.
 __attribute__((optnone))
 #endif
----------------
I think optnone has to remain attached to the function using __try, not the filter.


================
Comment at: llvm/lib/Support/CrashRecoveryContext.cpp:219
 
 bool CrashRecoveryContext::RunSafely(function_ref<void()> Fn) {
   if (!gCrashRecoveryEnabled) {
----------------
So, here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74078/new/

https://reviews.llvm.org/D74078