[PATCH] D73709: [PowerPC] Create a FixedStack object for CR save in linkage area.

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 14:43:54 PST 2020


jsji added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:1804
+  // function uses CR 2, 3, or 4. For 64-bit SVR4 we create a FixedStack
+  // object that aliases the CR-save slot in the linkage area. The actual save
+  // and restore of the condition register will be created as part of the
----------------
`aliases`? looks confusing, as `IsAliased` below is always false.


================
Comment at: llvm/test/CodeGen/PowerPC/ppc64-crsave.mir:10
+---
+name:            CRAllSave
+alignment:       16
----------------
Can we add some test with alloca in callee stack?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73709/new/

https://reviews.llvm.org/D73709





More information about the llvm-commits mailing list