[PATCH] D74056: [mlir][AVX512] Start an AVX512 dialect

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache marked 2 inline comments as done.
nicolasvasilache added a comment.

@flaub thanks! addressed.



================
Comment at: mlir/include/mlir/Dialect/Targets/AVX512/AVX512Ops.td:28
+    AllTypesMatch<["source", "result"]>]>,
+    // Supports either vector<16xf32> or vector<8xf64>.
+    Arguments<(ins VectorOfLengthAndType<[16], [F32]>:$source)>,
----------------
aartbik wrote:
> Bit new to this syntax, so please forgive this question ;-)
> 
> I see the 16xf32, but where is the 8xf64?
Dropped it because XNNPack does not target that atm (in that function at least).
Once I have all the pieces connected end-to-end we can think about generalizing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74056/new/

https://reviews.llvm.org/D74056