[PATCH] D73542: [LLD][ELF][ARM] Do not substitute BL/BLX for non STT_FUNC symbols.
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 5 13:21:38 PST 2020
psmith added a comment.
I know what the problem is, it is a stupid typo on my part that looks superficially correct and the non-strong enum hasn't saved me at the type checker.
bool interwork = (rel.sym && rel.sym->isFunc()) || rel.type == R_PLT_PC;
Spot the deliberate mistake, this should be rel.expr == R_PLT_PC. There is a similar error at the R_ARM_CALL change, but we are saved by ARM state to ARM state being correct with the non-interwork case. So this needs two changes and a test. I can do this tomorrow morning, but given the possible delay in getting the patch approved, I still think reverting and I'll resubmit makes sense as I don't trust myself with detail this late.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73542/new/
https://reviews.llvm.org/D73542
More information about the llvm-commits
mailing list