[PATCH] D70720: [llvm-objdump] Display locations of variables alongside disassembly

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

In D70720#1859405 <https://reviews.llvm.org/D70720#1859405>, @ostannard wrote:

> - Move DWARF expression printer into lib/DebugInfo/DWARF. I've left the LiveVariablePrinter class in llvm-objdump for now, because it's more tied into the rest of the disassembly loop (e.g. it needs to print after source line numbers). I'm not really sure what LLDB's requirements are here, but if we're going to move things to a library it might be worth moving more of the disassembly loop at the same time.


Agreed, this doesn't need to happen all at once.



================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:667
+  // since the last \n, and we use it to mean the number of slots in which we
+  // put live variable lines. Pick a less overloaded word.
+  unsigned moveToFirstVarColumn(formatted_raw_ostream &OS) {
----------------
Minor nit: It's encouraged to always use Doxygen (///) comments even in local definitions, because many IDEs can understand them and then dispaly online help and format the comments nicely.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70720/new/

https://reviews.llvm.org/D70720