[PATCH] D74083: MemCpyOpt cannot use ABI alignment even if it was not given

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 13:04:37 PST 2020


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp:178
+    if (!Align)
+      Align = DL.getABITypeAlignment(SI->getOperand(0)->getType());
+    addRange(OffsetFromFirst, StoreSize, SI->getPointerOperand(), Align, SI);
----------------
I'd suggest moving the `findStoreAlignment()` helper below higher up in the file and use that, as it implements the same logic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74083/new/

https://reviews.llvm.org/D74083





More information about the llvm-commits mailing list