[PATCH] D73542: [LLD][ELF][ARM] Do not substitute BL/BLX for non STT_FUNC symbols.

Wed Feb 5 12:19:59 PST 2020

MaskRay added a comment.

I left some comments in https://bugs.chromium.org/p/chromium/issues/detail?id=1047531 Can non-Google users comment there?

In D73542#1860353 <https://reviews.llvm.org/D73542#1860353>, @thakis wrote:

> We haven't used bfd.ld for chromium/android in many many years, and we haven't used gold in years. I don't know what the linker defaults are in the Android NDK, but I'd guess that they default to lld nowadays. (I haven't checked though.)
>
> If this affects us, it likely affects others.
>
> How would a warning for this work though?

This behavior change will require a new option. I hope there are only a few places needing updates so that we don't have to create a new option.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73542/new/

https://reviews.llvm.org/D73542