[PATCH] D74082: [MC][ELF] Rename MC related "Associated" to "LinkedToSym"

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 12:01:44 PST 2020


MaskRay created this revision.
MaskRay added reviewers: bd1976llvm, eugenis, grimar, jhenderson.
Herald added subscribers: llvm-commits, hiraditya, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

"linked-to section" is used by the ELF spec. By analogy, "linked-to
symbol" is a good name for the signature symbol.  The word "linked-to"
implies a directed edge and makes it clear its relation with "sh_link",
while one can argue that "associated" means an undirected edge.

Also, combine tests and add precise SMLoc to improve diagnostics.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74082

Files:
  llvm/include/llvm/MC/MCContext.h
  llvm/include/llvm/MC/MCSectionELF.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  llvm/lib/MC/ELFObjectWriter.cpp
  llvm/lib/MC/MCContext.cpp
  llvm/lib/MC/MCParser/ELFAsmParser.cpp
  llvm/lib/MC/MCSectionELF.cpp
  llvm/test/MC/ELF/metadata-declaration-errors.s
  llvm/test/MC/ELF/section-linkorder-error.s
  llvm/test/MC/ELF/section-metadata-err1.s
  llvm/test/MC/ELF/section-metadata-err2.s
  llvm/test/MC/ELF/section-metadata-err3.s
  llvm/test/MC/ELF/section-metadata-err4.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74082.242718.patch
Type: text/x-patch
Size: 16541 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200205/050248b0/attachment.bin>


More information about the llvm-commits mailing list