[PATCH] D70564: [GlobalISel] LegalizationArtifactCombiner: Fix a bug in tryCombineMerges

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 11:32:39 PST 2020


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:183-185
+  // Replace if DstReg has no constraints.
+  if (!DstBank && !DstRC)
+    return true;
----------------
arsenm wrote:
> Check these first and short circuit the source checks?
This can also use getRegClassOrRegBank instead of checking the two separately?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70564/new/

https://reviews.llvm.org/D70564





More information about the llvm-commits mailing list