[PATCH] D71959: [PassManagerBuilder] Remove global extension when a plugin is unloaded

Wed Feb 5 11:12:51 PST 2020

jkorous added a comment.

@serge-sans-paille The test was still failing on macOS.

http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/9061/consoleFull

  ******************** TEST 'LLVM :: Feature/load_extension.ll' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/clang-build/bin/opt /Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm-project/llvm/test/Feature/load_extension.ll -load=/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/clang-build/./lib/Bye.dylib -goodbye -wave-goodbye -disable-output 2>&1 | /Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/clang-build/bin/FileCheck /Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm-project/llvm/test/Feature/load_extension.ll
  --
  Exit Code: 1
  Hide Details

  Command Output (stderr):
  --
  /Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm-project/llvm/test/Feature/load_extension.ll:3:10: error: CHECK: expected string not found in input
  ; CHECK: Bye
           ^
  <stdin>:1:1: note: scanning from here
  opt: CommandLine Error: Option 'attributor-max-iterations' registered more than once!
  ^
  <stdin>:1:14: note: possible intended match here
  opt: CommandLine Error: Option 'attributor-max-iterations' registered more than once!

I disabled it again.

  commit 3524755a1a25c18ecf47e50e5186232da0751cfe (HEAD -> master, origin/master, origin/HEAD)
  Author: Jan Korous <jkorous at apple.com>
  Date:   Wed Feb 5 11:03:38 2020 -0800

      Revert "Activate extension loading test on Darwin now that the underlying fix has landed"

      This reverts commit 058070893428a480b76a137f647ae6b9c89ac2d4.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71959/new/

https://reviews.llvm.org/D71959