[PATCH] D73557: [GWP-ASan] Crash Handler API.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits



================
Comment at: compiler-rt/lib/gwp_asan/guarded_pool_allocator.cpp:194
+  // Raise a SEGV by touching the guard page closest on the left hand size.
+  volatile char *p = reinterpret_cast<char*>(getPageAddr(Address, State.PageSize) - 1);
+  *p = 0;
----------------
Could be simply the first guard page at *GuardPagePool. Does not really matter.


================
Comment at: compiler-rt/lib/gwp_asan/tests/harness.h:19
 #include "gwp_asan/options.h"
+#include "gwp_asan/optional/segv_handler.h"
 
----------------
this does not exist


================
Comment at: compiler-rt/lib/gwp_asan/tests/harness.h:94
+    GPA.uninitTestOnly();
+    gwp_asan::crash_handler::uninstallSignalHandlers();
+  }
----------------
Not a big deal, but it makes sense to do these things in the opposite order.


================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:12
 
+#include "/usr/local/google/home/mitchp/llvm/compiler-rt/lib/gwp_asan/optional/segv_handler.h"
 #include "chunk.h"
----------------
wrong path


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73557/new/

https://reviews.llvm.org/D73557