[PATCH] D73812: [CMake] Filter libc++abi and libunwind from runtimes build in MSVC

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/runtimes/CMakeLists.txt:30-31
 foreach(proj ${LLVM_ENABLE_RUNTIMES})
+  # TODO: libunwind and libcxxabi don't currently build on Windows so filter them out.
+  if((WIN32 AND NOT MINGW) AND ("${proj}" MATCHES "libunwind|libcxxabi"))
+    continue()
----------------
smeenai wrote:
> I think `MSVC` is a better condition here than `WIN32 AND NOT MINGW`, since libunwind and libc++abi aren't compatible with the MSVC ABI.
Done, I've also added a warning so it's easier to spot in the output.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73812/new/

https://reviews.llvm.org/D73812