[PATCH] D73933: [AArch64][GlobalISel] Fold G_ASHR into TB(N)Z bit calculation

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 09:55:50 PST 2020


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

LGTM with nit.



================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:1076
+      if (Bit >= MRI.getType(TestReg).getSizeInBits())
+        Bit = MRI.getType(TestReg).getSizeInBits() - 1;
+      break;
----------------
Can you factor our these getType() calls here and in the G_SHL case into a variable?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73933/new/

https://reviews.llvm.org/D73933





More information about the llvm-commits mailing list