[PATCH] D74065: [ValueTracking] Update implied reasoning to accept expanded cmp (NFC).

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LG, seems like a reasonable extension.

PS: What's up with the clang-format spam? Looks entirely bogus.



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:5687-5688
 
-  // The LHS should be an 'or' or an 'and' instruction.  We expect the RHS to be
-  // an icmp. FIXME: Add support for and/or on the RHS.
+  //// The LHS should be an 'or' or an 'and' instruction.  We expect the RHS to
+  /// be / an icmp. FIXME: Add support for and/or on the RHS.
   const BinaryOperator *LHSBO = dyn_cast<BinaryOperator>(LHS);
----------------
Something went wrong with the `////` here.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:5714
+
+static std::pair<Value *, bool>
+getDomPredecessorCondition(const Instruction *ContextI) {
----------------
Add comment for what the pair means? (Cond and CondIsTrue)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74065/new/

https://reviews.llvm.org/D74065