[PATCH] D74061: [mlir] Update generic op ebnf to include region

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar created this revision.
jpienaar added reviewers: rriddle, ftynse.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, mehdi_amini.
Herald added 1 blocking reviewer(s): rriddle.
Herald added a project: LLVM.

Optional regions are supported in the generic op print/parse form, update the docs to match.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74061

Files:
  mlir/docs/LangRef.md
  mlir/lib/Parser/Parser.cpp


Index: mlir/lib/Parser/Parser.cpp
===================================================================
--- mlir/lib/Parser/Parser.cpp
+++ mlir/lib/Parser/Parser.cpp
@@ -3573,7 +3573,8 @@
 ///  operation         ::= op-result-list?
 ///                        (generic-operation | custom-operation)
 ///                        trailing-location?
-///  generic-operation ::= string-literal '(' ssa-use-list? ')' attribute-dict?
+///  generic-operation ::= string-literal `(` ssa-use-list? `)`
+///                        (`(` region-list `)`)? attribute-dict?
 ///                        `:` function-type
 ///  custom-operation  ::= bare-id custom-operation-format
 ///  op-result-list    ::= op-result (`,` op-result)* `=`
Index: mlir/docs/LangRef.md
===================================================================
--- mlir/docs/LangRef.md
+++ mlir/docs/LangRef.md
@@ -241,7 +241,8 @@
 ```
 operation         ::= op-result-list? (generic-operation | custom-operation)
                       trailing-location?
-generic-operation ::= string-literal '(' ssa-use-list? ')' attribute-dict?
+generic-operation ::= string-literal `(` ssa-use-list? `)`
+                      (`(` region-list `)`)? attribute-dict?
                       `:` function-type
 custom-operation  ::= bare-id custom-operation-format
 op-result-list    ::= op-result (`,` op-result)* `=`


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74061.242637.patch
Type: text/x-patch
Size: 1361 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200205/fe973cfe/attachment.bin>