[PATCH] D73964: [NFC] Introduce an API for MemOp

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 07:44:32 PST 2020


courbet added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:170
+    assert(isMemset() && "Must be a memset");
+    return ZeroMemset;
+  }
----------------
To be consistent with `isMemcpyWithFixedDstAlign` this should be `isMemset() && ZeroMemset` (and the only usage is as a conjunction anyway)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73964/new/

https://reviews.llvm.org/D73964





More information about the llvm-commits mailing list