[PATCH] D74000: [X86] Improve the gather scheduler models for SkylakeClient and SkylakeServer

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

In D74000#1859033 <https://reviews.llvm.org/D74000#1859033>, @andreadb wrote:

> > I've added avx512 gather instructions to llvm-mca resource tests. I wanted to pre-commit them, but since some of them have 0 uops in the existing data, llvm-mca gave an error.
>
> What I can do in the short term is to remove the check for MayLoad and MayStore in mca (I have a patch ready for it). That check is too conservative, since we were already test if an instruction consumes processor resources in general. That is enough to fix the issue that you saw with zero uOP gathers.


FTR: I have committed aaaeac6 <https://reviews.llvm.org/rGaaaeac616692a6bdb0ee1e7a9977f7fde9dcb364> to remove those checks.
So, (if you really want to) you should be able now to precommit your new tests.

That being said. The patch looks good to me modulo the request from Simon.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74000/new/

https://reviews.llvm.org/D74000