[PATCH] D73999: [MC][ELF] Warn changed section type or flags

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

The warnings seem okay for now, though I do wonder whether really all the properties of a section should just be used in uniquely identifying a section.



================
Comment at: llvm/test/MC/ELF/section-flags-changed.s:10
+# CHECK: {{.*}}.s:[[# @LINE+1]]:1: warning: ignoring changed section flags for .foo
+.section .foo,"awo", at progbits,foo
+
----------------
Any reason you've tried to change the flags twice?


================
Comment at: llvm/test/MC/ELF/section-flags-changed.s:12
+
+.pushsection .foo,"ax", at progbits
----------------
Possibly worth a .pushsection case which changes the flags?


================
Comment at: llvm/test/MC/ELF/section-type-changed.s:9
+# CHECK: {{.*}}.s:[[# @LINE+1]]:1: warning: ignoring changed section type for .foo
+.section .foo,"a", at note
+
----------------
Any particular reason for this extra case here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73999/new/

https://reviews.llvm.org/D73999