[PATCH] D73764: [mlir] Added RankedIntElementsAttr class

[Lei Zhang via Phabricator via llvm-commits]

antiagainst accepted this revision.
antiagainst added a comment.

LGTM, just two nits regarding the test names.



================
Comment at: mlir/test/IR/attribute.mlir:276
+
+func @wrong_element_type_pass_2() {
+  // expected-error @+1 {{failed to satisfy constraint: 64-bit int elements attribute of shape [4, 8]}}
----------------
wrong_shape_fail ?


================
Comment at: mlir/test/IR/attribute.mlir:287
+
+func @unranked_element_type_pass() {
+  // expected-error @+1 {{failed to satisfy constraint: 32-bit int elements attribute of shape [2]}}
----------------
wrong_shape_fail ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73764/new/

https://reviews.llvm.org/D73764