[PATCH] D74037: [ARM][LowOverheadLoops] Fix loop count chain

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 05:04:52 PST 2020


SjoerdMeijer added a comment.

Looks like a good fix to me.

The tests are big, but it's probably good to have some larger tests too.



================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:727
+  RDA->getReachingLocalUses(LoLoop.Dec, ARM::LR, Uses);
+  if (Uses.size() > 1 || !Uses.count(LoLoop.End)) {
+    LLVM_DEBUG(dbgs() << "ARM Loops: Unable to remove LoopDec.\n");
----------------
Nit: I think some comments would be good here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74037/new/

https://reviews.llvm.org/D74037





More information about the llvm-commits mailing list