[PATCH] D74040: [ARM] Correct syntax of the CLRM insn

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 05:04:51 PST 2020


simon_tatham added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5210
                     (ins pred:$p, reglist_with_apsr:$regs, variable_ops),
-                    AddrModeNone, NoItinerary, "clrm", "${p}\t$regs", "", []> {
+                    AddrModeNone, NoItinerary, "clrm${p}", "\t$regs", "", []> {
   bits<16> regs;
----------------
This will generate an `AsmString` with two consecutive tab characters, because the `V8_1MI` base class inserts a `\t` between the `asm` and `ops` parameters, but you've put an extra `\t` in the `ops` string.

(I guess FileCheck normalizes out whitespace and so the test doesn't notice the difference.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74040/new/

https://reviews.llvm.org/D74040





More information about the llvm-commits mailing list