[PATCH] D74006: [MC][ELF] Make linked-to symbol name part of ELFSectionKey

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 5 00:50:35 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/include/llvm/MC/MCContext.h:217
+          return O < 0;
         return UniqueID < Other.UniqueID;
       }
----------------
grimar wrote:
> Perhaps just:
> ```
> if (UniqueID  != Other.UniqueID)
>   return UniqueID < Other.UniqueID;
> return LinkedToName < Other.LinkedToName;
> ```
The order is so that it matches the field order. Name fields placing together looks better, so I want to stick with the current order.

I can do a follow-up change to use `StringRef::compare` for SectionName and GroupName.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74006/new/

https://reviews.llvm.org/D74006





More information about the llvm-commits mailing list