[PATCH] D73716: [SCEV] SCEVExpander::isHighCostExpansionHelper(): begin cost modelling - model cast cost

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri marked 2 inline comments as done.
lebedev.ri added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolutionExpander.cpp:2164
+  if (auto *CastExpr = dyn_cast<SCEVCastExpr>(S)) {
+    unsigned Opcode;
+    switch (S->getSCEVType()) {
----------------
mkazantsev wrote:
> Does it really need to be opcode, or we can pass SCEVType to `getOperationCost`?
`TargetTransformInfo::getOperationCost()` has no such `SCEVType` overload.
it can only be called with either opcode or preexisting existing IR instruction.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73716/new/

https://reviews.llvm.org/D73716