[PATCH] D72947: [CMake] llvm/runtimes: Do not override LLVM_* variables with just-built LLVM configurations

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 22:43:39 PST 2020


smeenai added a comment.

Seems reasonable to me.

An alternative solution would be to change the generated LLVMConfig such that it checks if certain variables are already set before overriding them, but I'm not completely sure if that makes sense to do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72947/new/

https://reviews.llvm.org/D72947





More information about the llvm-commits mailing list