[PATCH] D74014: [mlir] [VectorOps] generalized vector.contract semantics

[Aart Bik via Phabricator via llvm-commits]

aartbik added inline comments.


================
Comment at: mlir/lib/Dialect/VectorOps/VectorOps.cpp:206
+static unsigned getTypeRank(Type type) {
+  auto vectorType = type.dyn_cast<VectorType>();
+  if (vectorType)
----------------
rriddle wrote:
> nit: Can you just inline this function? It only has one use case and isn't very large.
Yes, of course. I had bigger plans for this, but then only used it once :-)


================
Comment at: mlir/lib/Dialect/VectorOps/VectorOps.cpp:234
+    if (map.getNumDims() == 0 && map.getNumResults() == 0 && rank == 0)
+      continue; // (i) -> () is parsed into empty map; accept for rank=0
     if (map.getNumDims() != numIterators)
----------------
rriddle wrote:
> Is this supposed to be `except for`?
No, I meant "accept" as in continue without doing the tests below. But rephrased this into something better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74014/new/

https://reviews.llvm.org/D74014