[PATCH] D73901: [DebugInfo][test] Fix calculation of generated line table size

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 19:35:18 PST 2020


dblaikie added a comment.

In D73901#1856901 <https://reviews.llvm.org/D73901#1856901>, @jhenderson wrote:

> In D73901#1856447 <https://reviews.llvm.org/D73901#1856447>, @jhenderson wrote:
>
> > In D73901#1855137 <https://reviews.llvm.org/D73901#1855137>, @dblaikie wrote:
> >
> > > Perhaps worth a test case that exercises this new functionality/change in behavior?
> >
> >
> > I've got one in the pipeline (it's how I found this bug). Will upload later today.
>
>
> One of the unit tests introduced in D73962 <https://reviews.llvm.org/D73962> uses this functionality.


While small patches are generally good - changes in functionality should be exercised when added, so might be best to include this change in that one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73901/new/

https://reviews.llvm.org/D73901





More information about the llvm-commits mailing list