[PATCH] D74012: [mlir][spirv] Use spv.entry_point_abi in GPU to SPIR-V conversions

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 4 18:03:45 PST 2020


antiagainst created this revision.
antiagainst added a reviewer: denis13.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, aartbik, herhut, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: mravishankar.
Herald added a project: LLVM.

We have spv.entry_point_abi for specifying the local workgroup size.
It should be decorated onto input gpu.func ops to drive the SPIR-V
CodeGen to generate the proper SPIR-V module execution mode. Compared
to using command-line options for specifying the configuration, using
attributes also has the benefits that 1) we are now able to use
different local workgroup for different entry points and 2) the
tests contains the configuration directly.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74012

Files:
  mlir/include/mlir/Conversion/GPUToSPIRV/ConvertGPUToSPIRV.h
  mlir/include/mlir/Conversion/GPUToSPIRV/ConvertGPUToSPIRVPass.h
  mlir/include/mlir/Dialect/SPIRV/TargetAndABI.h
  mlir/lib/Conversion/GPUToSPIRV/ConvertGPUToSPIRV.cpp
  mlir/lib/Conversion/GPUToSPIRV/ConvertGPUToSPIRVPass.cpp
  mlir/lib/Dialect/SPIRV/TargetAndABI.cpp
  mlir/test/Conversion/GPUToSPIRV/builtins.mlir
  mlir/test/Conversion/GPUToSPIRV/if.mlir
  mlir/test/Conversion/GPUToSPIRV/load-store.mlir
  mlir/test/Conversion/GPUToSPIRV/loop.mlir
  mlir/test/Conversion/GPUToSPIRV/simple.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74012.242485.patch
Type: text/x-patch
Size: 19167 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200205/e3ec54fe/attachment.bin>


More information about the llvm-commits mailing list