[PATCH] D73983: [mlir][ODS] Add documentation for the declarative assembly format.

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar accepted this revision.
jpienaar marked an inline comment as done.
jpienaar added a comment.
This revision is now accepted and ready to land.

Looks good thanks



================
Comment at: mlir/docs/OpDefinitions.md:608
+
+A literal is either a keyword or punctuation surrounded by \`\`.
+
----------------
Does this render correctly with hugo?


================
Comment at: mlir/docs/OpDefinitions.md:623
+
+1. The output and operation name are never shown as they are fixed and cannot be
+   altered.
----------------
It might be good to point out that this is a requirement of parsing custom forms in general and not specific to this.


================
Comment at: mlir/docs/OpDefinitions.md:631
+1. The `attr-dict` directive must always be present.
+1. Must not contain overlapping information; e.g. multiple instances of
+   'attr-dict', types, operands, etc.
----------------
Are optional attributes handled? I'm assuming no special handling, only via attr-dict.


================
Comment at: mlir/docs/OpDefinitions.md:654-655
+these equal constraints to discern the types of missing variables. The currently
+supported traits are: `AllTypesMatch`, `SameTypeOperands`,
+and `SameOperandsAndResultType`.
+
----------------
Reflow?


================
Comment at: mlir/docs/OpDefinitions.md:1129
 
-### A proposal for auto-generating printer and parser methods
-
----------------
Awh, I just looked at when this was originally written :) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73983/new/

https://reviews.llvm.org/D73983