[PATCH] D72700: [DSE] Add first version of MemorySSA-backed DSE (Bottom up walk).

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1692
+
+      DeadInst->eraseFromParent();
+    }
----------------
asbirlea wrote:
> The MemDep variant of DSE also attempts to keep debug info. Does this also make sense here?
> ```
>     // Try to preserve debug information attached to the dead instruction.
>     salvageDebugInfo(*DeadInst);
> ```
Yes, we should definitely do this! I've updated it and there's a debug info test that passes now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72700/new/

https://reviews.llvm.org/D72700